mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 69097: Added an allocator benchmark for quota performance.
Date Fri, 02 Nov 2018 22:22:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69097/#review210291
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hierarchical_allocator_benchmarks.cpp
Lines 498-499 (patched)
<https://reviews.apache.org/r/69097/#comment294955>

    Why not make it even smaller (e.g. 1/4 or 1/10th) to be more pathological?



src/tests/hierarchical_allocator_benchmarks.cpp
Lines 601-609 (patched)
<https://reviews.apache.org/r/69097/#comment294956>

    No need for the comments, seems self explanatory?


- Benjamin Mahler


On Oct. 22, 2018, 10:32 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69097/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2018, 10:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-6630
>     https://issues.apache.org/jira/browse/MESOS-6630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This benchmark evaluates the allocator performance in
> the presence of roles with both small quota (which can
> be satisfied by half an agent) as well as large quota
> (which need resources from two agents). We setup the cluster,
> trigger one allocation cycle and measure the elapsed time.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a

> 
> 
> Diff: https://reviews.apache.org/r/69097/diff/1/
> 
> 
> Testing
> -------
> 
> Result from optimized build on a multicore 2.2GHz machine:
> 
> Benchmark setup: 20 agents, 25 roles, 25 frameworks
> Made 30 allocations in 11.01225ms
> Made 0 allocation in 5.758192ms
> 
> Benchmark setup: 200 agents, 250 roles, 250 frameworks
> Made 300 allocations in 337.974387ms
> Made 0 allocation in 313.298636ms
> 
> Benchmark setup: 2000 agents, 2500 roles, 2500 frameworks
> Made 3000 allocations in 27.881684393secs
> Made 0 allocation in 25.013398926secs
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message