mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.
Date Fri, 02 Nov 2018 22:02:00 GMT


> On Oct. 25, 2018, 12:22 a.m., Benjamin Mahler wrote:
> > src/tests/allocator.hpp
> > Lines 40-45 (patched)
> > <https://reviews.apache.org/r/69096/diff/1/?file=2101109#file2101109line40>
> >
> >     I think we some other create helpers lying around, e.g. createTask. Is this
where these belong?
> >     
> >     Do you think we need them?
> 
> Meng Zhu wrote:
>     I do not have use cases of other helpers in mind atm. Thus I prefer to pull in only
these two.

Do we even need these helpers? They seem pretty trivial, and I wonder how much code it's actually
simplifying. I'm fine with the patch, but it feels heavy to have a new header and compliation
unit just for these, especially since they're only used in two files and are trivial.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69096/#review210010
-----------------------------------------------------------


On Oct. 20, 2018, 1:28 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69096/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2018, 1:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helps to share the helpers between
> `hierarchical_allocator_tests.cpp` and
> `hierarchical_allocator_benchmarks.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 
>   src/tests/CMakeLists.txt 00dbdee1c06e7571fa799850cdaf7f2ccadc8bea 
>   src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
>   src/tests/allocator.cpp PRE-CREATION 
>   src/tests/hierarchical_allocator_tests.cpp 27fbd9cf0c4442e7675362a806d35bad141ffb6d

> 
> 
> Diff: https://reviews.apache.org/r/69096/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message