mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.
Date Fri, 02 Nov 2018 21:59:04 GMT


> On Oct. 25, 2018, 12:20 a.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_benchmarks.cpp
> > Line 234 (original), 234 (patched)
> > <https://reviews.apache.org/r/69093/diff/1/?file=2101097#file2101097line237>
> >
> >     Hm.. how were you able to change this while it remained correct? Was this just
an empty map always?
> 
> Meng Zhu wrote:
>     Yeah, it is currently not used. (So far there is only one benchmark in the suite
and it does not utilize it). During the fixture code review, I recommended Kapil to add the
option to specify used resources because some of the existing benchmarks in `hierarchical_allocator_test.cpp
` setup agents with pre-allocated resources.
>     
>     Now I realize that we can't easily do this during our cluster setup. Because when
we specify the `agentProfile`, no framework has been created yet. I am actually not quite
sure why we need to specify `used`. In the future if necessary, we can always create a bunch
of frameworks with their own quota roles to simulate this right after the cluster initialization.

Can you clarify some of this in the description?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69093/#review210007
-----------------------------------------------------------


On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69093/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2018, 1:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`,
> it is not easy to add agents with used resources because
> frameworks are created during the initialization which is
> after the agent profiles creation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a

> 
> 
> Diff: https://reviews.apache.org/r/69093/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message