mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 69234: Made debug container runs as its parent container's user by default.
Date Fri, 02 Nov 2018 21:38:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69234/#review210281
-----------------------------------------------------------




src/slave/http.cpp
Line 2516 (original), 2519 (patched)
<https://reviews.apache.org/r/69234/#comment294951>

    I would suggest to change the behavior for all nested container. If user is not specified,
always inherit from parent user.


- Gilbert Song


On Nov. 1, 2018, 2:25 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69234/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2018, 2:25 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9332
>     https://issues.apache.org/jira/browse/MESOS-9332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made debug container runs as its parent container's user by default.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 03a4e0f1567b27b2efd8a443caea3a2a087d858c

>   src/slave/http.cpp 0d27ab576d5fa52c06826703e3dad38c2d374cc9 
> 
> 
> Diff: https://reviews.apache.org/r/69234/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message