mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation.
Date Thu, 01 Nov 2018 20:33:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69233/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-9367
    https://issues.apache.org/jira/browse/MESOS-9367


Repository: mesos


Description
-------

Since the XFS disk isolator didn't check that the persistent volume
has a `DiskInfo::Source` before populating the corresponding field
in the `ResourceStatistics` message. This caused the JSON conversion
(triggered by operator API calls) to check fail. The fix is to simply
check that the volume has a `DiskInfo::Source` before propagating it.


Diffs
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 44b7d0570b00d50e1fc454100ab73f4dfe5ca159

  src/tests/containerizer/xfs_quota_tests.cpp b2f977f15e2ea8cbcccce5f1d60e046a8f7d3560 


Diff: https://reviews.apache.org/r/69233/diff/1/


Testing
-------

sudo make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message