mesos-reviews mailing list archives: October 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Kevin Klues Review Request 69104: Fixed formatting in subcommand help in the new CLI. Sat, 20 Oct, 09:30
Armand Grillet   Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI. Sat, 20 Oct, 09:37
Kevin Klues   Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI. Sat, 20 Oct, 09:37
Mesos Reviewbot Windows     Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI. Sat, 20 Oct, 11:52
Armand Grillet Review Request 69105: Added 'task atach' subcommand to new CLI. Sat, 20 Oct, 10:04
Kevin Klues   Re: Review Request 69105: Added 'task attach' subcommand to new CLI. Sat, 20 Oct, 10:53
Mesos Reviewbot Windows   Re: Review Request 69105: Added 'task attach' subcommand to new CLI. Sat, 20 Oct, 11:51
Benjamin Mahler Review Request 69109: Updated libprocess to log all socket errors consistently. Sun, 21 Oct, 23:40
Mesos Reviewbot Windows   Re: Review Request 69109: Updated libprocess to log all socket errors consistently. Mon, 22 Oct, 01:05
Gastón Kleiman   Re: Review Request 69109: Updated libprocess to log all socket errors consistently. Wed, 24 Oct, 21:36
Greg Mann Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 04:31
Mesos Reviewbot Windows   Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 05:27
Greg Mann   Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 05:35
Greg Mann     Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 05:35
Mesos Reviewbot Windows       Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 07:06
Alexander Rukletsov       Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 08:42
Greg Mann         Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 18:20
Mesos Reviewbot       Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 15:47
Greg Mann       Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 18:20
Greg Mann         Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 18:37
Mesos Reviewbot Windows           Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 22 Oct, 19:48
Alexander Rukletsov           Re: Review Request 69110: Added task health check definitions to master API responses. Tue, 23 Oct, 08:56
Greg Mann             Re: Review Request 69110: Added task health check definitions to master API responses. Thu, 25 Oct, 00:53
Greg Mann           Re: Review Request 69110: Added task health check definitions to master API responses. Thu, 25 Oct, 00:51
Mesos Reviewbot Windows             Re: Review Request 69110: Added task health check definitions to master API responses. Thu, 25 Oct, 03:06
Greg Mann             Re: Review Request 69110: Added task health check definitions to master API responses. Thu, 25 Oct, 21:01
Mesos Reviewbot Windows               Re: Review Request 69110: Added task health check definitions to master API responses. Thu, 25 Oct, 22:31
Greg Mann               Re: Review Request 69110: Added task health check definitions to master API responses. Fri, 26 Oct, 22:08
Gastón Kleiman                 Re: Review Request 69110: Added task health check definitions to master API responses. Fri, 26 Oct, 23:49
Mesos Reviewbot Windows                 Re: Review Request 69110: Added task health check definitions to master API responses. Sat, 27 Oct, 00:22
Greg Mann                 Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 29 Oct, 17:54
Mesos Reviewbot Windows                   Re: Review Request 69110: Added task health check definitions to master API responses. Mon, 29 Oct, 19:25
Armand Grillet Review Request 69114: Added 'exec_command' to test util functions for the new CLI. Mon, 22 Oct, 10:31
Kevin Klues   Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI. Mon, 22 Oct, 13:15
Armand Grillet   Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI. Mon, 22 Oct, 13:26
Kevin Klues     Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI. Mon, 22 Oct, 13:28
Armand Grillet Review Request 69048: Added tenacity to 'pip-requirements' for new CLI. Mon, 22 Oct, 10:31
Kevin Klues   Re: Review Request 69048: Added tenacity to 'pip-requirements' for new CLI. Mon, 22 Oct, 13:32
Armand Grillet Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 10:32
Mesos Reviewbot Windows   Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 12:05
Armand Grillet   Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 13:42
Kevin Klues     Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 13:45
Kevin Klues       Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 13:49
Armand Grillet     Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 14:13
Kevin Klues       Re: Review Request 69049: Added test for 'task exec'. Mon, 22 Oct, 14:18
Armand Grillet Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 12:00
Mesos Reviewbot Windows   Re: Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 13:32
Kevin Klues   Re: Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 14:32
Armand Grillet   Re: Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 14:40
Mesos Reviewbot Windows     Re: Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 16:24
Mesos Reviewbot     Re: Review Request 69115: Added test for interactive 'task exec'. Mon, 22 Oct, 22:01
Armand Grillet Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. Mon, 22 Oct, 12:23
Mesos Reviewbot Windows   Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. Mon, 22 Oct, 13:35
Mesos Reviewbot   Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. Mon, 22 Oct, 16:36
Armand Grillet Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'. Mon, 22 Oct, 14:12
Kevin Klues   Re: Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'. Mon, 22 Oct, 14:13
Re: Review Request 68016: Added libseccomp to the build.
Andrei Budnik   Re: Review Request 68016: Added libseccomp to the build. Mon, 22 Oct, 17:04
Re: Review Request 68019: Added a parser for the Docker Seccomp config format.
Andrei Budnik   Re: Review Request 68019: Added a parser for the Docker Seccomp config format. Mon, 22 Oct, 17:04
Re: Review Request 68018: Added `SeccompFilter` class.
James Peach   Re: Review Request 68018: Added `SeccompFilter` class. Mon, 22 Oct, 17:15
Re: Review Request 68017: Added Seccomp-related protobuf messages.
James Peach   Re: Review Request 68017: Added Seccomp-related protobuf messages. Mon, 22 Oct, 17:18
Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.
Mesos Reviewbot Windows   Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher. Mon, 22 Oct, 17:23
Mesos Reviewbot   Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher. Mon, 22 Oct, 22:52
Benjamin Mahler Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 23 Oct, 03:08
Mesos Reviewbot Windows   Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 23 Oct, 04:37
Vinod Kone   Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 23 Oct, 14:54
Benjamin Mahler     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 23 Oct, 17:48
Qian Zhang   Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Thu, 25 Oct, 08:07
Benjamin Mahler     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Thu, 25 Oct, 17:57
Qian Zhang     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Fri, 26 Oct, 03:24
Qian Zhang     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Fri, 26 Oct, 03:27
Benjamin Mahler     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Fri, 26 Oct, 18:25
Qian Zhang     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Mon, 29 Oct, 21:18
Benjamin Mahler     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 30 Oct, 19:01
Mesos Reviewbot   Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Thu, 25 Oct, 20:13
Benjamin Mahler   Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Fri, 26 Oct, 03:25
Qian Zhang     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 30 Oct, 20:48
Gilbert Song     Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier. Tue, 30 Oct, 22:09
James Peach Review Request 69132: Used mount(8) to make XFS loop device mounts. Tue, 23 Oct, 23:17
Mesos Reviewbot Windows   Re: Review Request 69132: Used mount(8) to make XFS loop device mounts. Wed, 24 Oct, 00:17
Ilya Pronin   Re: Review Request 69132: Used mount(8) to make XFS loop device mounts. Wed, 24 Oct, 00:59
James Peach     Re: Review Request 69132: Used mount(8) to make XFS loop device mounts. Wed, 24 Oct, 15:17
James Peach   Re: Review Request 69132: Used mount(8) to make XFS loop device mounts. Wed, 24 Oct, 15:41
Mesos Reviewbot Windows     Re: Review Request 69132: Used mount(8) to make XFS loop device mounts. Wed, 24 Oct, 17:15
Armand Grillet Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'. Wed, 24 Oct, 09:30
Mesos Reviewbot Windows   Re: Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'. Wed, 24 Oct, 10:55
Mesos Reviewbot   Re: Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'. Wed, 24 Oct, 18:27
Till Toenshoff via Review Board Review Request 69140: Allowed for unbundled libarchive on cmake builds. Wed, 24 Oct, 12:25
Till Toenshoff via Review Board   Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Wed, 24 Oct, 12:34
Till Toenshoff via Review Board   Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Wed, 24 Oct, 13:51
Mesos Reviewbot Windows   Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Wed, 24 Oct, 14:22
Joseph Wu   Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Wed, 24 Oct, 18:21
Till Toenshoff via Review Board     Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Tue, 30 Oct, 20:20
Till Toenshoff via Review Board     Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Tue, 30 Oct, 20:22
Joseph Wu     Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Tue, 30 Oct, 20:37
Till Toenshoff via Review Board   Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Tue, 30 Oct, 20:20
Joseph Wu     Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds. Tue, 30 Oct, 20:38
Re: Review Request 68812: Added example framework for inverse-offers.
Alexander Rukletsov   Re: Review Request 68812: Added example framework for inverse-offers. Wed, 24 Oct, 15:43
Till Toenshoff via Review Board   Re: Review Request 68812: Added example framework for inverse-offers. Fri, 26 Oct, 16:45
Till Toenshoff via Review Board     Re: Review Request 68812: Added example framework for inverse-offers. Fri, 26 Oct, 17:20
Mesos Reviewbot Windows       Re: Review Request 68812: Added example framework for inverse-offers. Fri, 26 Oct, 18:17
Benjamin Bannier Review Request 69082: Correctly propagated `close` failures in some instances. Wed, 24 Oct, 20:22
Mesos Reviewbot Windows   Re: Review Request 69082: Correctly propagated `close` failures in some instances. Wed, 24 Oct, 21:54
Meng Zhu Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 22:23
Meng Zhu   Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:12
Till Toenshoff via Review Board     Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:31
Joseph Wu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:37
Till Toenshoff via Review Board       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:39
Meng Zhu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:45
Till Toenshoff via Review Board       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Wed, 24 Oct, 23:47
Meng Zhu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 02:59
Chun-Hung Hsiao       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 03:20
Meng Zhu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 19:35
Mesos Reviewbot Windows     Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 00:16
Chun-Hung Hsiao     Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 03:27
Benjamin Bannier     Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 06:54
Meng Zhu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 19:35
Meng Zhu     Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 19:34
Mesos Reviewbot Windows       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Thu, 25 Oct, 21:06
Joseph Wu       Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox. Mon, 29 Oct, 20:18
James Peach Review Request 69149: Automatically remounted read-only bind mounts. Wed, 24 Oct, 23:49
Mesos Reviewbot Windows   Re: Review Request 69149: Automatically remounted read-only bind mounts. Thu, 25 Oct, 01:41
Ilya Pronin   Re: Review Request 69149: Automatically remounted read-only bind mounts. Fri, 26 Oct, 21:47
James Peach   Re: Review Request 69149: Automatically remounted read-only bind mounts. Fri, 26 Oct, 22:58
Mesos Reviewbot Windows     Re: Review Request 69149: Automatically remounted read-only bind mounts. Sat, 27 Oct, 03:02
GitBox [GitHub] watermeion opened a new pull request #315: fix Disarding a Future -> Discarding a Future Thu, 25 Oct, 07:22
Benjamin Bannier Review Request 69157: Fixed handling for offer operation updates. Thu, 25 Oct, 10:47
Benjamin Bannier Review Request 69158: Added an integration test for resource provider removal. Thu, 25 Oct, 10:47
Mesos Reviewbot Windows   Re: Review Request 69158: Added an integration test for resource provider removal. Thu, 25 Oct, 12:15
Benjamin Bannier Review Request 69159: Used an alias for reoccuring complicated type. Thu, 25 Oct, 10:54
Jan Schlicht   Re: Review Request 69159: Used an alias for reoccuring complicated type. Fri, 26 Oct, 11:48
Benjamin Bannier Review Request 69160: Included corresponding header file first. Thu, 25 Oct, 10:54
Jan Schlicht   Re: Review Request 69160: Included corresponding header file first. Fri, 26 Oct, 11:50
Till Toenshoff via Review Board   Re: Review Request 69160: Included corresponding header file first. Fri, 26 Oct, 13:49
Benjamin Bannier Review Request 69161: Renamed a function argument to not reuse member name. Thu, 25 Oct, 10:54
Benjamin Bannier Review Request 69162: Added agent and resource provider IDs to operation status messages. Thu, 25 Oct, 10:54
James DeFelice   Re: Review Request 69162: Added agent and resource provider IDs to operation status messages. Thu, 25 Oct, 12:13
Benjamin Bannier     Re: Review Request 69162: Added agent and resource provider IDs to operation status messages. Wed, 31 Oct, 14:38
Benjamin Bannier Review Request 69163: Set agent and/or resource provider ID in operation status updates. Thu, 25 Oct, 10:54
Mesos Reviewbot Windows   Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. Thu, 25 Oct, 13:40
Mesos Reviewbot   Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. Thu, 25 Oct, 18:02
Mesos Reviewbot Windows   Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. Wed, 31 Oct, 16:17
Mesos Reviewbot   Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. Wed, 31 Oct, 18:22
James DeFelice   Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. Wed, 31 Oct, 18:39
GitBox [GitHub] asfgit closed pull request #315: fix Disarding a Future -> Discarding a Future Thu, 25 Oct, 16:00
Andrei Budnik Review Request 69171: Added validation of cache files to the URI Fetcher. Thu, 25 Oct, 20:47
Joseph Wu   Re: Review Request 69171: Added validation of cache files to the URI Fetcher. Fri, 26 Oct, 23:20
Andrei Budnik     Re: Review Request 69171: Added validation of cache files to the URI Fetcher. Mon, 29 Oct, 22:34
Andrei Budnik   Re: Review Request 69171: Added validation of cache files to the URI Fetcher. Mon, 29 Oct, 22:33
Andrei Budnik Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test. Thu, 25 Oct, 20:47
Mesos Reviewbot Windows   Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test. Thu, 25 Oct, 22:31
Joseph Wu   Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test. Fri, 26 Oct, 23:24
Mesos Reviewbot   Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test. Sat, 27 Oct, 01:34
Meng Zhu Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Thu, 25 Oct, 23:11
Mesos Reviewbot Windows   Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Fri, 26 Oct, 00:46
Joseph Wu   Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Fri, 26 Oct, 22:30
Meng Zhu     Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Fri, 26 Oct, 23:01
Meng Zhu   Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Fri, 26 Oct, 23:00
Joseph Wu     Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`. Fri, 26 Oct, 23:31
Meng Zhu Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`. Thu, 25 Oct, 23:11
Mesos Reviewbot Windows   Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`. Fri, 26 Oct, 00:46
Joseph Wu   Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`. Fri, 26 Oct, 21:56
Meng Zhu     Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`. Fri, 26 Oct, 22:15
Joseph Wu Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint. Fri, 26 Oct, 00:51
Joseph Wu   Re: Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint. Fri, 26 Oct, 18:29
Joseph Wu Review Request 69181: Passed streaming decoder from master /api/v1 to master actor. Fri, 26 Oct, 00:53
Joseph Wu Review Request 69182: Moved Master::Subscribers::Subscriber constructor into .cpp file. Fri, 26 Oct, 00:54
Joseph Wu Review Request 69183: Added optional heartbeat monitoring to the master /api/v1. Fri, 26 Oct, 00:55
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Box list
May 2019301
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338