mesos-reviews mailing list archives: October 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Qian Zhang Review Request 69016: Added a test `SubprocessTest.WhiteListFds`. Sun, 14 Oct, 14:02
Qian Zhang   Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`. Sun, 14 Oct, 14:11
James Peach     Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`. Tue, 16 Oct, 15:52
Armand Grillet Review Request 69023: Added `retry` argument to `request()` method for Resource object. Mon, 15 Oct, 11:05
Kevin Klues   Re: Review Request 69023: Added `retry` argument to `request()` method in Python library. Wed, 17 Oct, 12:02
Armand Grillet Review Request 69026: Changed usage documentation for new CLI. Mon, 15 Oct, 11:45
Kevin Klues   Re: Review Request 69026: Changed usage documentation for new CLI. Mon, 15 Oct, 12:00
Mesos Reviewbot Windows   Re: Review Request 69026: Changed usage documentation for new CLI. Mon, 15 Oct, 13:21
Re: Review Request 67840: Renamed committer checklist into committer guidelines.
Gastón Kleiman   Re: Review Request 67840: Renamed committer checklist into committer guidelines. Mon, 15 Oct, 17:23
James Peach   Re: Review Request 67840: Renamed committer checklist into committer guidelines. Mon, 15 Oct, 17:27
Alexander Rukletsov   Re: Review Request 67840: Renamed committer checklist into committer guidelines. Mon, 15 Oct, 17:43
Re: Review Request 67841: Updated committer candidate guidelines.
Gastón Kleiman   Re: Review Request 67841: Updated committer candidate guidelines. Mon, 15 Oct, 17:26
Alexander Rukletsov   Re: Review Request 67841: Updated committer candidate guidelines. Mon, 15 Oct, 17:43
Mesos Reviewbot Windows     Re: Review Request 67841: Updated committer candidate guidelines. Mon, 15 Oct, 19:11
Mesos Reviewbot     Re: Review Request 67841: Updated committer candidate guidelines. Tue, 16 Oct, 01:01
Chun-Hung Hsiao Review Request 69033: Fixed a comment in SLRP. Mon, 15 Oct, 22:09
Mesos Reviewbot Windows   Re: Review Request 69033: Fixed a comment in SLRP. Mon, 15 Oct, 23:34
Benjamin Bannier   Re: Review Request 69033: Fixed a comment in SLRP. Mon, 29 Oct, 20:19
Mesos Reviewbot   Re: Review Request 69033: Fixed a comment in SLRP. Mon, 29 Oct, 22:42
Re: Review Request 65784: Added validation of QuotaRequest.
Benjamin Mahler   Re: Review Request 65784: Added validation of QuotaRequest. Mon, 15 Oct, 22:17
Chun-Hung Hsiao Review Request 69035: Added a comment for `Resource.provider_id`. Tue, 16 Oct, 04:07
Meng Zhu   Re: Review Request 69035: Added a comment for `Resource.provider_id`. Wed, 31 Oct, 18:24
Re: Review Request 69036: WIP: Added an optional `profile` field to `CreateDisk`.
Mesos Reviewbot Windows   Re: Review Request 69036: WIP: Added an optional `profile` field to `CreateDisk`. Tue, 16 Oct, 05:39
Chun-Hung Hsiao   Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Wed, 17 Oct, 23:21
James DeFelice     Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Thu, 18 Oct, 01:15
Chun-Hung Hsiao     Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Mon, 22 Oct, 18:50
Chun-Hung Hsiao       Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Tue, 23 Oct, 02:37
James DeFelice         Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Tue, 23 Oct, 14:51
Chun-Hung Hsiao           Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Tue, 30 Oct, 21:16
James DeFelice           Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Wed, 31 Oct, 13:52
Benjamin Bannier         Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Tue, 30 Oct, 21:30
Re: Review Request 69037: WIP: Added an optional `vendor` field to `DiskInfo.Source`.
Mesos Reviewbot Windows   Re: Review Request 69037: WIP: Added an optional `vendor` field to `DiskInfo.Source`. Tue, 16 Oct, 07:04
Benjamin Bannier Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements. Tue, 16 Oct, 10:23
Jan Schlicht   Re: Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements. Wed, 17 Oct, 09:01
Benjamin Mahler   Re: Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements. Wed, 17 Oct, 17:57
Benjamin Bannier Review Request 69042: Enabled more constructors for master `RegistryOperation`. Tue, 16 Oct, 10:23
Mesos Reviewbot Windows   Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`. Tue, 16 Oct, 11:55
Jan Schlicht   Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`. Wed, 17 Oct, 08:53
Mesos Reviewbot   Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`. Wed, 17 Oct, 15:03
Benjamin Mahler   Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`. Wed, 17 Oct, 17:53
Armand Grillet Review Request 69047: Updated Python library to be easier to handle as a Python module. Tue, 16 Oct, 11:31
Kevin Klues   Re: Review Request 69047: Updated Python library to be easier to handle as a Python module. Tue, 16 Oct, 11:42
Review Request 69043: Disabled warnings-as-errors for cares build.
Benno Evers   Review Request 69043: Disabled warnings-as-errors for cares build. Tue, 16 Oct, 12:03
Mesos Reviewbot Windows     Re: Review Request 69043: Disabled warnings-as-errors for cares build. Tue, 16 Oct, 15:24
Benjamin Bannier   Re: Review Request 69043: Disabled warnings-as-errors for cares build. Wed, 17 Oct, 13:31
Benjamin Mahler Review Request 69052: Added a test to ensure UUID size, variant, version. Tue, 16 Oct, 18:57
Benjamin Mahler Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes). Tue, 16 Oct, 18:57
James DeFelice   Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes). Tue, 16 Oct, 19:04
Gastón Kleiman   Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes). Tue, 16 Oct, 20:16
Mesos Reviewbot Windows   Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes). Tue, 16 Oct, 20:25
Re: Review Request 68089: Added LevelDB compaction after replicated log truncation.
Benjamin Mahler   Re: Review Request 68089: Added LevelDB compaction after replicated log truncation. Tue, 16 Oct, 21:02
Benjamin Mahler   Re: Review Request 68089: Added LevelDB compaction after replicated log truncation. Tue, 16 Oct, 21:09
Re: Review Request 68090: Added log_auto_compact flag to the master.
Benjamin Mahler   Re: Review Request 68090: Added log_auto_compact flag to the master. Tue, 16 Oct, 21:03
Meng Zhu Review Request 69032: Optimized resources filter operation. Tue, 16 Oct, 23:16
Benjamin Mahler   Re: Review Request 69032: Optimized resources filter operation. Wed, 17 Oct, 00:24
Meng Zhu     Re: Review Request 69032: Optimized resources filter operation. Fri, 19 Oct, 04:23
Mesos Reviewbot Windows   Re: Review Request 69032: Optimized resources filter operation. Wed, 17 Oct, 01:22
Meng Zhu   Re: Review Request 69032: Optimized resources filter operation. Fri, 19 Oct, 04:22
Mesos Reviewbot Windows     Re: Review Request 69032: Optimized resources filter operation. Fri, 19 Oct, 05:56
Mesos Reviewbot     Re: Review Request 69032: Optimized resources filter operation. Fri, 19 Oct, 12:29
Gilbert Song Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 08:00
Qian Zhang   Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 08:02
Mesos Reviewbot Windows   Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 08:56
James Peach   Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 15:30
Andrei Budnik   Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 15:43
Gilbert Song   Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp. Wed, 17 Oct, 21:27
Re: Review Request 68147: Added agent support to remove local resource providers.
Benjamin Bannier   Re: Review Request 68147: Added agent support to remove local resource providers. Wed, 17 Oct, 14:07
Benjamin Bannier   Re: Review Request 68147: Added agent support to remove local resource providers. Thu, 25 Oct, 10:47
Benjamin Bannier   Re: Review Request 68147: Added agent support to remove local resource providers. Wed, 31 Oct, 14:38
Benno Evers Review Request 68795: Added deduplication for read-only master requests. Wed, 17 Oct, 15:10
Benno Evers   Re: Review Request 68795: Added deduplication for read-only master requests. Thu, 18 Oct, 18:43
Benno Evers Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. Wed, 17 Oct, 15:10
Mesos Reviewbot Windows   Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. Wed, 17 Oct, 15:42
Mesos Reviewbot   Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. Wed, 17 Oct, 23:05
Benno Evers   Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. Thu, 18 Oct, 18:43
Mesos Reviewbot Windows     Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints. Thu, 18 Oct, 21:15
Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs.
Jiang Yan Xu   Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs. Wed, 17 Oct, 17:49
James Peach   Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs. Wed, 17 Oct, 22:21
Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI.
Jiang Yan Xu   Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI. Wed, 17 Oct, 17:52
Jiang Yan Xu   Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI. Wed, 17 Oct, 18:10
James Peach     Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI. Wed, 17 Oct, 19:52
Meng Zhu Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct. Wed, 17 Oct, 23:41
Benjamin Mahler   Re: Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct. Thu, 18 Oct, 00:08
Mesos Reviewbot Windows   Re: Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct. Thu, 18 Oct, 01:10
Meng Zhu   Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance. Thu, 18 Oct, 01:14
Mesos Reviewbot     Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance. Thu, 18 Oct, 01:29
Mesos Reviewbot Windows     Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance. Thu, 18 Oct, 02:47
Benno Evers Review Request 69071: Narrowed interface of `ReadOnlyHandler` members. Thu, 18 Oct, 18:43
Till Toenshoff via Review Board Review Request 69075: Updated docker image fetcher to enforce HTTP1.1. Thu, 18 Oct, 22:57
James Peach   Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1. Thu, 18 Oct, 23:00
Till Toenshoff via Review Board   Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1. Thu, 18 Oct, 23:03
Till Toenshoff via Review Board     Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0. Thu, 18 Oct, 23:41
Till Toenshoff via Review Board       Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0. Fri, 19 Oct, 00:11
Mesos Reviewbot Windows       Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0. Fri, 19 Oct, 00:26
Till Toenshoff via Review Board       Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. Mon, 22 Oct, 11:22
Armand Grillet         Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. Mon, 22 Oct, 12:11
Mesos Reviewbot Windows         Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. Mon, 22 Oct, 13:32
James Peach         Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. Mon, 22 Oct, 16:03
Till Toenshoff via Review Board           Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x. Mon, 22 Oct, 16:08
Till Toenshoff via Review Board         Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1. Mon, 22 Oct, 16:22
James Peach           Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1. Mon, 22 Oct, 16:35
Mesos Reviewbot Windows           Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1 where needed. Mon, 22 Oct, 17:21
Armand Grillet Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable. Fri, 19 Oct, 15:22
Mesos Reviewbot Windows   Re: Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable. Fri, 19 Oct, 16:57
James Peach Review Request 69086: Move the container `/dev` construction to the isolators. Fri, 19 Oct, 17:38
James Peach   Re: Review Request 69086: Move the container `/dev` construction to the isolators. Fri, 19 Oct, 17:53
Mesos Reviewbot Windows   Re: Review Request 69086: Move the container `/dev` construction to the isolators. Fri, 19 Oct, 18:06
Mesos Reviewbot Windows   Re: Review Request 69086: Move the container `/dev` construction to the isolators. Fri, 19 Oct, 20:58
Jie Yu   Re: Review Request 69086: Move the container `/dev` construction to the isolators. Mon, 29 Oct, 04:42
James Peach     Re: Review Request 69086: Move the container `/dev` construction to the isolators. Mon, 29 Oct, 16:20
James Peach     Re: Review Request 69086: Move the container `/dev` construction to the isolators. Mon, 29 Oct, 23:57
Mesos Reviewbot   Re: Review Request 69086: Move the container `/dev` construction to the isolators. Mon, 29 Oct, 17:31
James Peach   Re: Review Request 69086: Moved container root construction to the isolators. Mon, 29 Oct, 23:59
James Peach     Re: Review Request 69086: Moved container root construction to the isolators. Tue, 30 Oct, 21:03
Chun-Hung Hsiao Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Fri, 19 Oct, 17:54
Benjamin Bannier   Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Mon, 22 Oct, 18:05
Chun-Hung Hsiao     Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Mon, 22 Oct, 20:29
Benjamin Bannier     Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Wed, 24 Oct, 20:50
Benjamin Bannier   Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Wed, 24 Oct, 20:50
Chun-Hung Hsiao     Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Wed, 24 Oct, 23:01
Chun-Hung Hsiao   Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Wed, 24 Oct, 23:02
Benjamin Bannier     Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Thu, 25 Oct, 13:20
Chun-Hung Hsiao       Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Mon, 29 Oct, 21:11
Chun-Hung Hsiao     Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`. Mon, 29 Oct, 21:12
Chun-Hung Hsiao       Re: Review Request 69085: Stout: Added a sync option for `mkdir`. Tue, 30 Oct, 21:07
Benjamin Mahler Review Request 69089: Eliminated excessive label copying in the task label decorator hook. Fri, 19 Oct, 20:35
Mesos Reviewbot Windows   Re: Review Request 69089: Eliminated excessive label copying in the task label decorator hook. Fri, 19 Oct, 22:23
Meng Zhu   Re: Review Request 69089: Eliminated excessive label copying in the task label decorator hook. Fri, 19 Oct, 23:51
Meng Zhu Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. Sat, 20 Oct, 01:27
Benjamin Mahler   Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. Thu, 25 Oct, 00:18
Meng Zhu     Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. Thu, 25 Oct, 18:04
Meng Zhu Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. Sat, 20 Oct, 01:27
Benjamin Mahler   Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. Thu, 25 Oct, 00:20
Meng Zhu     Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. Thu, 25 Oct, 03:09
Meng Zhu Review Request 69094: Renamed one allocator benchmark to be more descriptive. Sat, 20 Oct, 01:27
Benjamin Mahler   Re: Review Request 69094: Renamed one allocator benchmark to be more descriptive. Thu, 25 Oct, 00:20
Meng Zhu Review Request 69095: Added `hierarchical_allocator_benchmarks.cpp` to `CMakeLists.txt`. Sat, 20 Oct, 01:27
Benjamin Mahler   Re: Review Request 69095: Added `hierarchical_allocator_benchmarks.cpp` to `CMakeLists.txt`. Thu, 25 Oct, 00:20
Meng Zhu Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`. Sat, 20 Oct, 01:28
Benjamin Mahler   Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`. Thu, 25 Oct, 00:22
Meng Zhu     Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`. Thu, 25 Oct, 03:15
Meng Zhu Review Request 69097: Added an allocator benchmark for quota performance. Sat, 20 Oct, 01:29
Mesos Reviewbot Windows   Re: Review Request 69097: Added an allocator benchmark for quota performance. Sat, 20 Oct, 03:38
Meng Zhu   Re: Review Request 69097: Added an allocator benchmark for quota performance. Mon, 22 Oct, 22:32
Meng Zhu Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. Sat, 20 Oct, 06:05
Mesos Reviewbot Windows   Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. Sat, 20 Oct, 07:36
Mesos Reviewbot   Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. Sat, 20 Oct, 13:11
Meng Zhu   Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. Mon, 22 Oct, 22:39
Kevin Klues Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. Sat, 20 Oct, 08:57
Armand Grillet   Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. Sat, 20 Oct, 09:02
Kevin Klues   Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. Sat, 20 Oct, 09:52
Mesos Reviewbot Windows     Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. Sat, 20 Oct, 10:25
Jie Yu     Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'. Wed, 24 Oct, 03:21
Message list« Previous · 1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Box list
Sep 2019237
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338