From reviews-return-83056-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 25 00:18:18 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40B5918931 for ; Thu, 25 Oct 2018 00:18:18 +0000 (UTC) Received: (qmail 31911 invoked by uid 500); 25 Oct 2018 00:18:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31878 invoked by uid 500); 25 Oct 2018 00:18:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31866 invoked by uid 99); 25 Oct 2018 00:18:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Oct 2018 00:18:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1FBB01A2ED7; Thu, 25 Oct 2018 00:18:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id f9dSU--HwoVc; Thu, 25 Oct 2018 00:18:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B477A5F21F; Thu, 25 Oct 2018 00:18:15 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D9A4E00CB; Thu, 25 Oct 2018 00:18:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EE047C40546; Thu, 25 Oct 2018 00:18:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5978271218892175728==" MIME-Version: 1.0 Subject: Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. From: Benjamin Mahler To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler Cc: Meng Zhu , mesos Date: Thu, 25 Oct 2018 00:18:14 -0000 Message-ID: <20181025001814.39451.96919@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69092/ X-Sender: Benjamin Mahler References: <20181020012718.12843.58253@reviews-vm2.apache.org> In-Reply-To: <20181020012718.12843.58253@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============5978271218892175728== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210006 ----------------------------------------------------------- Hm.. I don't understand what this is doing. Is this setting default framework behavior if someone writing a benchmark doesn't want to have to pass the arguments? - Benjamin Mahler On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69092/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2018, 1:27 a.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > For frameworks that do not care about launching tasks, we should > provide some default task launch settings to simplify the benchmark > settings. > > > Diffs > ----- > > src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a > > > Diff: https://reviews.apache.org/r/69092/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > > --===============5978271218892175728==--