From reviews-return-82955-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Oct 22 16:35:21 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D23DF18780 for ; Mon, 22 Oct 2018 16:35:21 +0000 (UTC) Received: (qmail 67097 invoked by uid 500); 22 Oct 2018 16:35:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 67071 invoked by uid 500); 22 Oct 2018 16:35:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 67047 invoked by uid 99); 22 Oct 2018 16:35:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 16:35:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A8863C1B1D; Mon, 22 Oct 2018 16:35:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id O3b2DMGdFdvS; Mon, 22 Oct 2018 16:35:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B331D5F1BE; Mon, 22 Oct 2018 16:35:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 09E0DE00A6; Mon, 22 Oct 2018 16:35:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D0617C400DB; Mon, 22 Oct 2018 16:35:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8831253251842805947==" MIME-Version: 1.0 Subject: Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1. From: James Peach To: Jie Yu , Armand Grillet , James Peach , Alexander Rukletsov Cc: Till Toenshoff , mesos Date: Mon, 22 Oct 2018 16:35:17 -0000 Message-ID: <20181022163517.48649.42749@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69075/ X-Sender: James Peach X-ReviewBoard-ShipIt: 1 References: <20181022162217.48648.40207@reviews-vm2.apache.org> In-Reply-To: <20181022162217.48648.40207@reviews-vm2.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============8831253251842805947== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209873 ----------------------------------------------------------- Fix it, then Ship it! src/uri/fetchers/docker.cpp Lines 124 (patched) I think we can improve this comment .. > the HTTP 1.1 locking ?? > therefor therefore Maybe: ``` Older curl versions do not support the HTTP.1.1 flag, but these versions are also old enough to not default to HTTP/2. ``` - James Peach On Oct. 22, 2018, 4:22 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69075/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 4:22 p.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and James Peach. > > > Bugs: MESOS-8907 > https://issues.apache.org/jira/browse/MESOS-8907 > > > Repository: mesos > > > Description > ------- > > Modifies the 'curl' invocation that is returning an http::Response, > locking it into HTTP 1.1. Our current HTTP parser is unable to process > HTTP 2 responses. > > With the advent of curl 7.47, HTTPS connections are being enforced > towards HTTP 2 rather aggressively. As a result, our image fetcher > fails when recent curl versions are being used for pulling images from > a registry that supports HTTP 2. > > HTTP 1.1 is chosen as long as the underlying curl supports the > '--http1.1' flag. If curl is old enough to not support that flag, we > can deduct that it will not enforce HTTP 2 and therefor need no > further actions. > > For allowing all the benefits of HTTP 2 where possible, we do not > adapt any 'curl' invocations that do not attempt to parse headers. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 6b1277f822dcf80d44daa8133b3ecc8c9a34ef07 > > > Diff: https://reviews.apache.org/r/69075/diff/4/ > > > Testing > ------- > > `make check` > `sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. > > > Thanks, > > Till Toenshoff > > --===============8831253251842805947==--