From reviews-return-82894-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Oct 20 01:27:35 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA8DE18F03 for ; Sat, 20 Oct 2018 01:27:35 +0000 (UTC) Received: (qmail 46834 invoked by uid 500); 20 Oct 2018 01:27:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46793 invoked by uid 500); 20 Oct 2018 01:27:35 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46746 invoked by uid 99); 20 Oct 2018 01:27:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Oct 2018 01:27:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 95B39180AED; Sat, 20 Oct 2018 01:27:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KSVYAIhOtwR0; Sat, 20 Oct 2018 01:27:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 55AE85F300; Sat, 20 Oct 2018 01:27:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 05976E00D4; Sat, 20 Oct 2018 01:27:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E27C5C4047F; Sat, 20 Oct 2018 01:27:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2178605798543727041==" MIME-Version: 1.0 Subject: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. From: Meng Zhu To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler Cc: Meng Zhu , mesos Date: Sat, 20 Oct 2018 01:27:32 -0000 Message-ID: <20181020012732.12643.85783@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69093/ X-Sender: Meng Zhu Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============2178605798543727041== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69093/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository: mesos Description ------- Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`, it is not easy to add agents with used resources because frameworks are created during the initialization which is after the agent profiles creation. Diffs ----- src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a Diff: https://reviews.apache.org/r/69093/diff/1/ Testing ------- make check Thanks, Meng Zhu --===============2178605798543727041==--