From reviews-return-82789-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 16 23:16:06 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D5771940C for ; Tue, 16 Oct 2018 23:16:06 +0000 (UTC) Received: (qmail 58892 invoked by uid 500); 16 Oct 2018 23:16:06 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 58861 invoked by uid 500); 16 Oct 2018 23:16:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58845 invoked by uid 99); 16 Oct 2018 23:16:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 23:16:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D7930C1D6D; Tue, 16 Oct 2018 23:16:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id d9ao2h-mxhHg; Tue, 16 Oct 2018 23:16:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E64275F478; Tue, 16 Oct 2018 23:16:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 402D3E0177; Tue, 16 Oct 2018 23:16:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 12E60C402C8; Tue, 16 Oct 2018 23:16:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5621176308767428682==" MIME-Version: 1.0 Subject: Review Request 69032: Optimized resources filter operation. From: Meng Zhu To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler Cc: Meng Zhu , mesos Date: Tue, 16 Oct 2018 23:16:01 -0000 Message-ID: <20181016231601.39640.59556@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69032/ X-Sender: Meng Zhu Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============5621176308767428682== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9325 https://issues.apache.org/jira/browse/MESOS-9325 Repository: mesos Description ------- Currently, `Resources::filter()` operation uses `add()` which scans the resources vector, a O(n) operation. This is not necessary. `filter()` operation should only remove `Resource` entires. This patch optimizes the performance by directly `push_back` the resource to the vector without scanning. Diffs ----- src/common/resources.cpp f0f3df579550d874e477e2d6e7d0e87df079358a src/v1/resources.cpp 4d2b64f6e30ef96b47fc0b72b00158864e245650 Diff: https://reviews.apache.org/r/69032/diff/1/ Testing ------- make check Thanks, Meng Zhu --===============5621176308767428682==--