From reviews-return-82751-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 16 10:23:31 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7516019A3A for ; Tue, 16 Oct 2018 10:23:31 +0000 (UTC) Received: (qmail 69303 invoked by uid 500); 16 Oct 2018 10:23:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 69277 invoked by uid 500); 16 Oct 2018 10:23:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 68712 invoked by uid 99); 16 Oct 2018 10:23:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 10:23:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E4732C2CCB; Tue, 16 Oct 2018 10:23:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.95 X-Spam-Level: * X-Spam-Status: No, score=1.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, MANY_SPAN_IN_TEXT=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1P-Y6vljwFcI; Tue, 16 Oct 2018 10:23:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A0B225F174; Tue, 16 Oct 2018 10:23:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54F47E0360; Tue, 16 Oct 2018 10:23:28 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 45C52C40015; Tue, 16 Oct 2018 10:23:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3107687984155510819==" MIME-Version: 1.0 Subject: Review Request 69042: Enabled more constructors for master `RegistryOperation`. From: Benjamin Bannier To: Chun-Hung Hsiao , Benjamin Mahler Cc: Benjamin Bannier , mesos Date: Tue, 16 Oct 2018 10:23:28 -0000 Message-ID: <20181016102328.3759.86362@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69042/ X-Sender: Benjamin Bannier Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============3107687984155510819== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. Repository: mesos Description ------- Since this class was explicitly declaring a constructor, no other constructors such as copy or move constructors were generated. This patch removes the custom constructor so all default constructors are generated automatically. This e.g., enables move construction of `RegistryOperation` values. Diffs ----- src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 Diff: https://reviews.apache.org/r/69042/diff/1/ Testing ------- `make check` Without this patch a clang close to trunk would warn ``` ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted] AdaptedOperation(AdaptedOperation&&) = default; ^ ../src/resource_provider/registrar.cpp:374:28: note: move constructor of 'AdaptedOperation' is implicitly deleted because base class 'master::RegistryOperation' has a deleted move constructor class AdaptedOperation : public master::RegistryOperation ^ ../src/master/registrar.hpp:45:27: note: copy constructor of 'RegistryOperation' is implicitly deleted because base class 'process::Promise' has an inaccessible copy constructor class RegistryOperation : public process::Promise ^ ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] AdaptedOperation& operator=(AdaptedOperation&&) = default; ^ ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator of 'AdaptedOperation' is implicitly deleted because base class 'master::RegistryOperation' has a deleted move assignment operator class AdaptedOperation : public master::RegistryOperation ^ ../src/master/registrar.hpp:45:27: note: copy assignment operator of 'RegistryOperation' is implicitly deleted because base class 'process::Promise' has an inaccessible copy assignment operator class RegistryOperation : public process::Promise ^ 2 warnings generated. ``` No warning is emitted with this patch. Thanks, Benjamin Bannier --===============3107687984155510819==--