mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.
Date Tue, 30 Oct 2018 21:30:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review210147
-----------------------------------------------------------



Partial review.

I still wonder whether we should mention CSI in these interfaces at all; I am not sure it
adds much.


include/mesos/mesos.proto
Lines 2016-2017 (patched)
<https://reviews.apache.org/r/69036/#comment294782>

    Let's change emphasis here to mention that _frameworks should make sure this is valid
or we'd reject the operation_.


- Benjamin Bannier


On Oct. 23, 2018, 4:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2018, 4:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/4/
> 
> 
> Testing
> -------
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message