mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 69188: Ensured failed / discarded cgroups OOM notification is logged.
Date Tue, 30 Oct 2018 19:19:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69188/#review210180
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Oct. 28, 2018, 9:11 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69188/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2018, 9:11 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9334
>     https://issues.apache.org/jira/browse/MESOS-9334
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Failed or discarded OOM notificaitions in the cgroups memory
> subsystem were not being logged, due to the continuation being
> accidentally set up using `onReady` rather than `onAny`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp f4ed8337253995250cb533fa0a232909cb1a824b

> 
> 
> Diff: https://reviews.apache.org/r/69188/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message