mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.
Date Mon, 29 Oct 2018 21:12:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69085/
-----------------------------------------------------------

(Updated Oct. 29, 2018, 9:12 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9281
    https://issues.apache.org/jira/browse/MESOS-9281


Repository: mesos


Description
-------

To ensure the directories created by `mkdir` are commited to their
filesystems, an `fsync` will be called on the parent of each created
directory.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/mkdir.hpp 418db9af310ed763a5ae4735c2ebdd1ca38738ba



Diff: https://reviews.apache.org/r/69085/diff/3/

Changes: https://reviews.apache.org/r/69085/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message