mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.
Date Thu, 25 Oct 2018 18:04:33 GMT


> On Oct. 24, 2018, 5:18 p.m., Benjamin Mahler wrote:
> > Hm.. I don't understand what this is doing. Is this setting default framework behavior
if someone writing a benchmark doesn't want to have to pass the arguments?

That is correct.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69092/#review210006
-----------------------------------------------------------


On Oct. 19, 2018, 6:27 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69092/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For frameworks that do not care about launching tasks, we should
> provide some default task launch settings to simplify the benchmark
> settings.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a

> 
> 
> Diff: https://reviews.apache.org/r/69092/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message