mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.
Date Wed, 24 Oct 2018 23:01:49 GMT


> On Oct. 24, 2018, 8:50 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/os/posix/mkdir.hpp
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/69085/diff/1/?file=2100406#file2100406line64>
> >
> >     We need to reset `errno` before invoking `::mkdir` to make sure we don't pick
up a lingering preexisting `errno`.

Instead of relying on `errno` being zero, I've altered the logic a bit to only call `fsync`
if `::mkdir` actually succeeds.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69085/#review209984
-----------------------------------------------------------


On Oct. 19, 2018, 5:54 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69085/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2018, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9281
>     https://issues.apache.org/jira/browse/MESOS-9281
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To ensure the directories created by `mkdir` are commited to their
> filesystems, an `fsync` will be called on the parent of each created
> directory.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/mkdir.hpp 418db9af310ed763a5ae4735c2ebdd1ca38738ba

> 
> 
> Diff: https://reviews.apache.org/r/69085/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message