mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 69146: Made fetcher tests more robust by using the test sandbox.
Date Wed, 24 Oct 2018 22:23:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69146/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Gilbert Song.


Repository: mesos


Description
-------

Fetcher tests currently rely on some hard-coded paths,
for example, `/tmp/mesos/fetcher` and `/tmp/frameworks`.
Thus fetcher tests could fail if these directories already
exit. This patch makes use of the test sandboxes.
The above paths will be replaced by `fetch/` and `frameworks/`
under the sandbox.


Diffs
-----

  src/tests/fetcher_tests.cpp 283238cdda17a94e034baa195bd9d4b57e363b8a 


Diff: https://reviews.apache.org/r/69146/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message