mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 68953: Refactor allocator configuration into a struct.
Date Wed, 24 Oct 2018 22:17:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
-----------------------------------------------------------

(Updated Oct. 24, 2018, 10:17 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
    https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
-------

There has been a proliferation of configuration
passed into the allocator. This commit collects
that configuration into an `Options` struct.
Test fixes have been added as well.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 7b31c9d55dfae8a5da63f9d6e5db90bd4388bd92 
  src/master/allocator/mesos/hierarchical.cpp c89a63dd0e2beab64890cb2e4100d9fe903b86e9 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 
  src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b 
  src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 
  src/tests/hierarchical_allocator_benchmarks.cpp bf9167b63747f7b8a402d950947028436307082a

  src/tests/hierarchical_allocator_tests.cpp 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
  src/tests/master_allocator_tests.cpp 88288ae8528900b017941db9b07f5f83649fa096 
  src/tests/master_quota_tests.cpp f669396569c92609ee75ea7ae427eb5f5769bfd9 
  src/tests/reservation_tests.cpp d6931220139d91620c886591d7916079b8541982 
  src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca 
  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/68953/diff/9/

Changes: https://reviews.apache.org/r/68953/diff/8-9/


Testing
-------

make check on OSX


Thanks,

Jacob Janco


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message