mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.
Date Mon, 22 Oct 2018 21:21:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69009/
-----------------------------------------------------------

(Updated Oct. 22, 2018, 9:21 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Removed unnecessary blank lines.


Bugs: MESOS-9281
    https://issues.apache.org/jira/browse/MESOS-9281


Repository: mesos


Description
-------

This patch adds an option for the caller to sync the file and directory
contents to the disk after a write to prevent filesystem inconsistency
against reboots.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/fsync.hpp 9a6bbf6c51b0a7d6085924733e33d8b4f1bbc1ac

  3rdparty/stout/include/stout/os/posix/rename.hpp 9cff6db16c8a4e5a79bf0082e18a1133bd287796

  3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4

  3rdparty/stout/include/stout/os/write.hpp cd35285a9595004bac627abf687588050aef8161 
  3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b 


Diff: https://reviews.apache.org/r/69009/diff/5/

Changes: https://reviews.apache.org/r/69009/diff/4-5/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message