mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1.
Date Mon, 22 Oct 2018 16:22:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69075/
-----------------------------------------------------------

(Updated Oct. 22, 2018, 4:22 p.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and James Peach.


Changes
-------

Updated again to address recent comment by James - thanks a bunch!


Summary (updated)
-----------------

Updated docker image fetcher to enforce HTTP 1.1.


Bugs: MESOS-8907
    https://issues.apache.org/jira/browse/MESOS-8907


Repository: mesos


Description (updated)
-------

Modifies the 'curl' invocation that is returning an http::Response,
locking it into HTTP 1.1. Our current HTTP parser is unable to process
HTTP 2 responses.

With the advent of curl 7.47, HTTPS connections are being enforced
towards HTTP 2 rather aggressively. As a result, our image fetcher
fails when recent curl versions are being used for pulling images from
a registry that supports HTTP 2.

HTTP 1.1 is chosen as long as the underlying curl supports the
'--http1.1' flag. If curl is old enough to not support that flag, we
can deduct that it will not enforce HTTP 2 and therefor need no
further actions.

For allowing all the benefits of HTTP 2 where possible, we do not
adapt any 'curl' invocations that do not attempt to parse headers.


Diffs (updated)
-----

  src/uri/fetchers/docker.cpp 6b1277f822dcf80d44daa8133b3ecc8c9a34ef07 


Diff: https://reviews.apache.org/r/69075/diff/4/

Changes: https://reviews.apache.org/r/69075/diff/3-4/


Testing
-------

`make check`
`sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system with curl 7.59.0 installed.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message