mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69089: Eliminated excessive label copying in the task label decorator hook.
Date Fri, 19 Oct 2018 23:51:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69089/#review209815
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Oct. 19, 2018, 1:35 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69089/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2018, 1:35 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9336
>     https://issues.apache.org/jira/browse/MESOS-9336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This eliminates copying of the task labels in three cases:
> 
>   * In the master when mutating the task with the hook's labels.
>   * In the hook manager when mutating labels on a copy of the task.
>   * In the hook manager when returning the labels.
> 
> We still copy the entire task info once and then each hook
> has to copy the labels, but eliminating these requires an
> interface change.
> 
> 
> Diffs
> -----
> 
>   src/hook/manager.cpp eaca93af9167e5662d7ad57bcdae0cf20dcb64b6 
>   src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
> 
> 
> Diff: https://reviews.apache.org/r/69089/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message