mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <>
Subject Review Request 69089: Eliminated excessive label copying in the task label decorator hook.
Date Fri, 19 Oct 2018 20:35:33 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Meng Zhu and Till Toenshoff.

Bugs: MESOS-9336

Repository: mesos


This eliminates copying of the task labels in three cases:

  * In the master when mutating the task with the hook's labels.
  * In the hook manager when mutating labels on a copy of the task.
  * In the hook manager when returning the labels.

We still copy the entire task info once, but eliminating that
requires an interface change.


  src/hook/manager.cpp eaca93af9167e5662d7ad57bcdae0cf20dcb64b6 
  src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 



make check


Benjamin Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message