mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable.
Date Fri, 19 Oct 2018 16:57:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69084/#review209789
-----------------------------------------------------------



PASS: Mesos patch 69084 was successfully built and tested.

Reviews applied: `['69084']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2490/mesos-review-69084

- Mesos Reviewbot Windows


On Oct. 19, 2018, 3:22 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69084/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We list the files in 'MESOS_CLI_SRCDIR' when building the new CLI.
> We were previously using 'find' and then removing the files in
> the virtual environment but this is not enough as we now also
> use tools like 'tox' which creates files we do not care about.
> 
> To filter more while simplifying the build step, we now use 'git
> ls-files' to get a list of the files we need when building. Git
> is a dependency of Apache Mesos and the files we have in the
> repository are the only ones required to build the CLI,
> making this solution simpler yet more future-proof.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 
> 
> 
> Diff: https://reviews.apache.org/r/69084/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> $ ./src/mesos
> Mesos CLI
> ...
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message