mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.
Date Thu, 18 Oct 2018 18:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

Since all endpoints handled by `ReadOnlyHandler` will ignore all parts of the request except
for the query parameters, we enforce this invariant in the type system by changing the parameter
types.

This also enables a correct implementation of request caching in the subsequent commit.


Diffs
-----

  src/master/http.cpp d912789bcfdcf6eaefc29dba7b878fa4e02f9276 
  src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 
  src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29 


Diff: https://reviews.apache.org/r/69071/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message