mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.
Date Thu, 18 Oct 2018 01:15:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review209727
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 2003 (patched)
<https://reviews.apache.org/r/69036/#comment294269>

    "... with the profile specified in this call."
    
    This is true only if the profile being asked for is mapped to parameters that are permitted
by the CSI plugin. In other words, just picking any old profile won't work - it's the framework
author's job to remember (or otherwise be aware of) the correct profile to use here. It might
be worth noting that.



include/mesos/mesos.proto
Lines 2030 (patched)
<https://reviews.apache.org/r/69036/#comment294271>

    This has me a bit concerned: if Mesos loses CSI metadata about the volume and won't deprovision
it .. then how does one go about actually removing it via Mesos APIs to reclaim space in the
storage pool?


- James DeFelice


On Oct. 17, 2018, 11:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2018, 11:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/2/
> 
> 
> Testing
> -------
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message