mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs.
Date Wed, 17 Oct 2018 22:21:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68587/
-----------------------------------------------------------

(Updated Oct. 17, 2018, 10:21 p.m.)


Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-9172
    https://issues.apache.org/jira/browse/MESOS-9172


Repository: mesos


Description
-------

If a fetch request contains duplicate URIs that are not already
in the cache, the fetcher would erroneously expect that some other
fetch process is going to download that cache entry. It will then
wait for a Future that will never complete.

The fix is to track whether the cache entry was created in this
fetch, and in that case to simply allow the duplicate URI. In
the fetcher, we check the cache before downloading so that a URIs
can be fetched to distinct output files without being downloaded
multiple times.


Diffs (updated)
-----

  src/launcher/fetcher.cpp ef8d7ebdcf6d5d15459fd3392cb99774f078347a 
  src/slave/containerizer/fetcher.cpp 17f5388200c8341936cb4d7f8da67b5f286b727d 
  src/tests/fetcher_tests.cpp f3ea7092635c88b9dddcc2998a4c7350fb56110c 


Diff: https://reviews.apache.org/r/68587/diff/2/

Changes: https://reviews.apache.org/r/68587/diff/1-2/


Testing
-------

make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message