mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI.
Date Wed, 17 Oct 2018 19:52:05 GMT


> On Oct. 17, 2018, 6:10 p.m., Jiang Yan Xu wrote:
> > include/mesos/type_utils.hpp
> > Lines 532 (patched)
> > <https://reviews.apache.org/r/68586/diff/1/?file=2079296#file2079296line532>
> >
> >     So `cache` is counted here. Does it mean that if I specify two duplicate URIs
with different `cache` values one will overwrite another in fetching?

Yes, that would happen.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68586/#review209710
-----------------------------------------------------------


On Aug. 31, 2018, 4:47 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68586/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2018, 4:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-9172
>     https://issues.apache.org/jira/browse/MESOS-9172
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `output_file` field of the `CommandInfo::URI` is not combined
> into the hash value. This means that the fetcher does not consider two
> messages that differ only by the `output_file` as different. By adding
> the `output_file` to the hash it is possible for a task to fetch the
> same URI to multiple, distinct ouptuts.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa 
>   include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb 
> 
> 
> Diff: https://reviews.apache.org/r/68586/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message