mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.
Date Wed, 17 Oct 2018 19:30:22 GMT


> On Oct. 17, 2018, 9:52 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/os/write.hpp
> > Lines 128-130 (original), 139-141 (patched)
> > <https://reviews.apache.org/r/69009/diff/3/?file=2098277#file2098277line139>
> >
> >     This comment is still incorrect, especially with `sync=false`. I can file a
follow up patch which should probably propagate a possible error from `os::close` if `result`
wasn't already in an error state.

Still, I'm not sure if changing the error semantics is a good idea. If the caller want the
data to be flushed out, then set `sync=true` should do it. I'll update the comment to include
`fsync`.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69009/#review209689
-----------------------------------------------------------


On Oct. 16, 2018, 2:45 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69009/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2018, 2:45 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9281
>     https://issues.apache.org/jira/browse/MESOS-9281
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an option for the caller to sync the file and directory
> contents to the disk after a write to prevent filesystem inconsistency
> against reboots.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/fsync.hpp 9a6bbf6c51b0a7d6085924733e33d8b4f1bbc1ac

>   3rdparty/stout/include/stout/os/posix/rename.hpp 9cff6db16c8a4e5a79bf0082e18a1133bd287796

>   3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4

>   3rdparty/stout/include/stout/os/write.hpp cd35285a9595004bac627abf687588050aef8161

>   3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b

> 
> 
> Diff: https://reviews.apache.org/r/69009/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message