mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69043: Disabled warnings-as-errors for cares build.
Date Wed, 17 Oct 2018 13:31:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69043/#review209694
-----------------------------------------------------------


Ship it!




- Benjamin Bannier


On Oct. 17, 2018, 11:27 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69043/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2018, 11:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9302
>     https://issues.apache.org/jira/browse/MESOS-9302
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Attempting to build Mesos with default flags using gcc 8
> failed because the third-party dependency `cares`, which
> is bundled with `grpc`, was adding `-Werror` to its default
> compiler flags, which triggered on two new warning that
> gcc gained.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am c69eebeb7eed066cc1d27fd2eccfc8b770a3970d 
> 
> 
> Diff: https://reviews.apache.org/r/69043/diff/1/
> 
> 
> Testing
> -------
> 
> * Started internal CI run (#4626).
> * Started build on Fedora 28 machine and observed successful build of grpc dependency.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message