mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements.
Date Wed, 17 Oct 2018 09:01:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69041/#review209688
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/include/process/future.hpp
Line 710 (original), 710 (patched)
<https://reviews.apache.org/r/69041/#comment294239>

    Nit: This is redundant.


- Jan Schlicht


On Oct. 16, 2018, 12:23 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69041/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2018, 12:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables construction and assignment from rvalues for
> `Promise` values.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp ba2120190ad6e6814ab268f3e00911904e739e8e

> 
> 
> Diff: https://reviews.apache.org/r/69041/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message