mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.
Date Tue, 16 Oct 2018 22:26:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/
-----------------------------------------------------------

(Updated Oct. 16, 2018, 10:26 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8156
    https://issues.apache.org/jira/browse/MESOS-8156


Repository: mesos


Description
-------

Started using to `net::socketpair` in `ns::clone` so that we don't
have to deal with `SOCK_CLOEXEC` portability.


Diffs (updated)
-----

  src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4 


Diff: https://reviews.apache.org/r/63655/diff/4/

Changes: https://reviews.apache.org/r/63655/diff/3-4/


Testing
-------

make check (Fedora 26, macOS)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message