mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.
Date Tue, 16 Oct 2018 15:52:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/#review209637
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp
Lines 1067 (patched)
<https://reviews.apache.org/r/69016/#comment294177>

    Just a suggestion ... you could avoid the need for temporary files by using `dup` or `socket`
to create file descriptors.


- James Peach


On Oct. 14, 2018, 2:11 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69016/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152 and MESOS-9164
>     https://issues.apache.org/jira/browse/MESOS-9152
>     https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `SubprocessTest.WhiteListFds`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9

> 
> 
> Diff: https://reviews.apache.org/r/69016/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message