mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 69043: Disabled warnings-as-errors for cares build.
Date Tue, 16 Oct 2018 12:03:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69043/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-9302
    https://issues.apache.org/jira/browse/MESOS-9302


Repository: mesos


Description
-------

Attempting to build Mesos with default flags using gcc 8
failed because the third-party dependency `cares`, which
is bundled with `grpc`, was adding `-Werror` to its default
compiler flags, which triggered on two new warning that
gcc gained.


Diffs
-----

  3rdparty/Makefile.am c69eebeb7eed066cc1d27fd2eccfc8b770a3970d 


Diff: https://reviews.apache.org/r/69043/diff/1/


Testing
-------

* Started internal CI run (#4626).
* Started build on Fedora 28 machine and observed successful build of grpc dependency.


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message