mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63654: Added a `net::socketpair` helper to stout.
Date Tue, 16 Oct 2018 10:07:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63654/#review209607
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/os/posix/socket.hpp
Lines 97 (patched)
<https://reviews.apache.org/r/63654/#comment294131>

    Fits on a single line.



3rdparty/stout/include/stout/os/posix/socket.hpp
Lines 142-146 (patched)
<https://reviews.apache.org/r/63654/#comment294132>

    Indent by two spaces less,
    ```
    if (::setsockopt(
          result[0],
          ...
    ```



3rdparty/stout/include/stout/os/posix/socket.hpp
Lines 146 (patched)
<https://reviews.apache.org/r/63654/#comment294134>

    Nit: I believe `sizeof(enable)` would be marginally clearer.



3rdparty/stout/include/stout/os/posix/socket.hpp
Lines 152-156 (patched)
<https://reviews.apache.org/r/63654/#comment294133>

    Ditto.



3rdparty/stout/include/stout/os/posix/socket.hpp
Lines 156 (patched)
<https://reviews.apache.org/r/63654/#comment294135>

    Ditto.


- Benjamin Bannier


On Oct. 1, 2018, 7:36 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63654/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2018, 7:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8156
>     https://issues.apache.org/jira/browse/MESOS-8156
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `net::socketpair` helper to stout that deals with
> automatically setting O_CLOEXEC and disabling SIGPIPE where
> necessary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/socket.hpp 5557394e9ce8e4addc07d328d55274a9d573dfcd

>   3rdparty/stout/tests/os/sendfile_tests.cpp e334f489756e6f3352e7b1e84aabb9d40b734138

> 
> 
> Diff: https://reviews.apache.org/r/63654/diff/4/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26, macOS)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message