mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gustav Paul <gustav.p...@gmail.com>
Subject Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.
Date Mon, 15 Oct 2018 17:38:15 GMT


> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/os/write.hpp
> > Lines 133-134 (patched)
> > <https://reviews.apache.org/r/69009/diff/2/?file=2097012#file2097012line133>
> >
> >     Is the performance impact in the comment common knowledge? I would have expected
that implementation asked to `write` with `O_SYNC` could internally perform the equivalent
of what we are doing by hand here.
> >     
> >     If possible just use `O_SYNC` with `os::open` above.
> 
> Chun-Hung Hsiao wrote:
>     I've seen some benchmark about `O_SYNC` (which syncs for every write`) vs one single
`fsync`. Let me find it later.

http://lkml.iu.edu/hypermail/linux/kernel/0105.3/0353.html


- Gustav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69009/#review209538
-----------------------------------------------------------


On Oct. 12, 2018, 11:53 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69009/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2018, 11:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9281
>     https://issues.apache.org/jira/browse/MESOS-9281
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an option for the caller to sync the file and directory
> contents to the disk after a write to prevent filesystem inconsistency
> against reboots.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/rename.hpp 9cff6db16c8a4e5a79bf0082e18a1133bd287796

>   3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4

>   3rdparty/stout/include/stout/os/write.hpp cd35285a9595004bac627abf687588050aef8161

>   3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b

> 
> 
> Diff: https://reviews.apache.org/r/69009/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message