mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.
Date Fri, 12 Oct 2018 17:43:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review209494
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp
Line 130 (original)
<https://reviews.apache.org/r/68646/#comment293963>

    Since you are fixing MESOS-9164 here as well, update the the "Bugs" field, and the corresponsing
JIRA.


- James Peach


On Sept. 6, 2018, 1:25 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68646/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152
>     https://issues.apache.org/jira/browse/MESOS-9152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated launchers to use subprocess's `whitelist_fds` parameter.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launcher.cpp a18bdff6b64f978b87af16c2655d07ba8553bc95

>   src/slave/containerizer/mesos/linux_launcher.cpp e9ab36a16b24a123a660506d55f16dea16dee911

> 
> 
> Diff: https://reviews.apache.org/r/68646/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message