mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
Date Tue, 09 Oct 2018 14:01:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68965/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-8795
    https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description
-------

Added try/catch statements when using Mesos util functions in new CLI.


Diffs
-----

  src/python/cli_new/lib/cli/plugins/agent/main.py 5e821b36162cea8183f233a86181144daeca0753

  src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251



Diff: https://reviews.apache.org/r/68965/diff/1/


Testing
-------

```
(mesos-cli) ?  cli_new (MESOS-8795) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 4 tests in 5.350s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message