mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
Date Tue, 09 Oct 2018 12:16:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------

(Updated Oct. 9, 2018, 2:16 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Published Kevin's review request.


Bugs: MESOS-8025
    https://issues.apache.org/jira/browse/MESOS-8025


Repository: mesos


Description
-------

Updated address sanitization in new CLI to accept DNS names.


Diffs (updated)
-----

  src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf 
  src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db 
  src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a 


Diff: https://reviews.apache.org/r/66683/diff/6/

Changes: https://reviews.apache.org/r/66683/diff/5-6/


Testing
-------

Ran `mesos agent list` successfully with config:
```
[master]
  address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos
master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log'
--registry=in_memory`.

Also ran `mesos-cli-tests` successfully.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message