mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <>
Subject Review Request 68951: Updated to use current interpreter in subprocesses.
Date Mon, 08 Oct 2018 18:06:42 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Till Toenshoff and Vinod Kone.

Bugs: MESOS-9253

Repository: mesos


This changes the command used in `support/` when
running `support/` as a subprocess. It was previously
`"python"`, which is generally Python 2, and is now `sys.executable`.

That way, if is run with Python 3 (as it should), will be run with the same Python 3 interpreter. This
should fix the `ImportError` issues we have recently seen in our CI.


  support/ 56321ae65b38a1c62f5589b6a8aaa3993fa3dd5f 



I have created a simple `` file to check that the interpreter was correctly found:

import sys

def apply_review(review_id):
    """Apply a review using the script"""
    print("Applying review %s" % review_id)
    print("%s support/ -n -r %s" % (sys.executable, review_id))


In both cases, `python3` prints `/usr/local/bin/python3 support/ -n
-r 1337` which is what I expected.


Armand Grillet

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message