mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
Date Mon, 08 Oct 2018 06:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68923/#review209298
-----------------------------------------------------------



Do we plan to close it when backporting to 1.4.x finished?

- Gilbert Song


On Oct. 4, 2018, 3:14 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68923/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2018, 3:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-9283
>     https://issues.apache.org/jira/browse/MESOS-9283
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the Docker library to consistently use the
> overload of subprocess() which runs its binary via exec()
> rather than through a shell. This makes it safe to use
> os::kill() rather than os::killtree() when discarding
> these commands, which this patch also accomplishes.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 
>   src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 
> 
> 
> Diff: https://reviews.apache.org/r/68923/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message