mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.
Date Sun, 07 Oct 2018 15:45:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68945/#review209292
-----------------------------------------------------------



Bad patch!

Reviews applied: [68945, 68944]

Failed command: python support/apply-reviews.py -n -r 68944

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 35, in <module>
    import urllib.request
ImportError: No module named request

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23457/console

- Mesos Reviewbot


On Oct. 7, 2018, 3:16 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68945/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2018, 3:16 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There is no good reason to provide two c-tors for `MethodNotAllowed`,
> with one taking `requestMethod` and one not. Instead, an `Option<>`
> can be used. This also removes the need for copy-paste in the c-tor
> body.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp cef511a1563a26e170ce7f4a49de12776b4512e7

> 
> 
> Diff: https://reviews.apache.org/r/68945/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on various linux distros
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message