mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 68945: Fused constructors of `MethodNotAllowed` into one.
Date Sun, 07 Oct 2018 15:16:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68945/
-----------------------------------------------------------

Review request for mesos and Benno Evers.


Repository: mesos


Description
-------

There is no good reason to provide two c-tors for `MethodNotAllowed`,
with one taking `requestMethod` and one not. Instead, an `Option<>`
can be used. This also removes the need for copy-paste in the c-tor
body.


Diffs
-----

  3rdparty/libprocess/include/process/http.hpp cef511a1563a26e170ce7f4a49de12776b4512e7 


Diff: https://reviews.apache.org/r/68945/diff/1/


Testing
-------

`make check` on various linux distros


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message