mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.
Date Sat, 06 Oct 2018 00:54:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68929/#review209282
-----------------------------------------------------------



PASS: Mesos patch 68929 was successfully built and tested.

Reviews applied: `['68929']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2429/mesos-review-68929

- Mesos Reviewbot Windows


On Oct. 5, 2018, 11:30 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68929/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2018, 11:30 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-9295
>     https://issues.apache.org/jira/browse/MESOS-9295
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If there are new cgroup subsystems are added after the agent upgrad
> or recovery, new nested container launched under old containers that
> are launched before the recovery would fail, because it cannot assign
> its pid to the non-existed cgroup hierarchy. We should skip those
> new cgroup subsystems for nested containers under old containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 11dfbab182487c45fa494c41e31f777272b4b5d0

> 
> 
> Diff: https://reviews.apache.org/r/68929/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message