mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.
Date Sat, 06 Oct 2018 00:37:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67414/#review209280
-----------------------------------------------------------



Bad patch!

Reviews applied: [67414]

Failed command: python support/apply-reviews.py -n -r 67414

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 35, in <module>
    import urllib.request
ImportError: No module named request

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23456/console

- Mesos Reviewbot


On Oct. 5, 2018, 4:45 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67414/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2018, 4:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8999
>     https://issues.apache.org/jira/browse/MESOS-8999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By default on error libprocess would only return a response
> with the correct status code and no response body.
> 
> However, most browsers do not visually indicate the response
> status code, making it hard for the user to figure out what
> exactly the problem was.
> 
> A rudimentary text-only body is added to the default body of HTTP
> error responses, mirroring the approach taken by e.g. the Go
> standard library or Python's http.server module.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp fa66b0fe2ed72e218b235ac4b697a2a294027527

> 
> 
> Diff: https://reviews.apache.org/r/67414/diff/2/
> 
> 
> Testing
> -------
> 
> Started `make check` on various different platforms (Run #4563)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message