mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.
Date Fri, 05 Oct 2018 23:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68929/
-----------------------------------------------------------

(Updated Oct. 5, 2018, 4:30 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-9295
    https://issues.apache.org/jira/browse/MESOS-9295


Repository: mesos


Description (updated)
-------

If there are new cgroup subsystems are added after the agent upgrad
or recovery, new nested container launched under old containers that
are launched before the recovery would fail, because it cannot assign
its pid to the non-existed cgroup hierarchy. We should skip those
new cgroup subsystems for nested containers under old containers.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 11dfbab182487c45fa494c41e31f777272b4b5d0



Diff: https://reviews.apache.org/r/68929/diff/2/

Changes: https://reviews.apache.org/r/68929/diff/1-2/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message