mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.
Date Fri, 05 Oct 2018 16:45:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67414/
-----------------------------------------------------------

(Updated Oct. 5, 2018, 4:45 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Rebased onto latest master and applied `clang-format` on the lines changed in this patch.


Bugs: MESOS-8999
    https://issues.apache.org/jira/browse/MESOS-8999


Repository: mesos


Description (updated)
-------

By default on error libprocess would only return a response
with the correct status code and no response body.

However, most browsers do not visually indicate the response
status code, making it hard for the user to figure out what
exactly the problem was.

A rudimentary text-only body is added to the default body of HTTP
error responses, mirroring the approach taken by e.g. the Go
standard library or Python's http.server module.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp fa66b0fe2ed72e218b235ac4b697a2a294027527 


Diff: https://reviews.apache.org/r/67414/diff/2/

Changes: https://reviews.apache.org/r/67414/diff/1-2/


Testing (updated)
-------

Started `make check` on various different platforms (Run #4563)


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message