mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.
Date Fri, 05 Oct 2018 15:49:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68939/#review209268
-----------------------------------------------------------


Ship it!




Thanks a bunch Armand - huge improvement.
I guess, at some point we should also question the usefulness of lines like this:
```
Checking 1 C++ file
Done processing 3rdparty/libprocess/include/process/http.hpp
```

My most favorite solution here would not log at all unless there are issues, especially given
that both things are in no way actionable for the user. However, I also guess on the other
hand that "Checking..." stuff is useful if the linting introduces a considerable delay - which
in my experience actually can happen in cases where changes happened on our monster "master.cpp".

Thanks again!

- Till Toenshoff


On Oct. 5, 2018, 3:28 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68939/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2018, 3:28 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9056
>     https://issues.apache.org/jira/browse/MESOS-9056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated cpplint.py to be less verbose when there is no linting issue.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 30778d9cfcf3c884b7f7d3d4c811631a1d8d182b 
>   support/cpplint.py c5a45f7608d7d41bd9fc1b03640c418ecf31e534 
> 
> 
> Diff: https://reviews.apache.org/r/68939/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> ?  apache-mesos (MESOS-9056) ? python3 support/apply-reviews.py -r 68813
> 2018-10-05 17:25:01 URL:https://reviews.apache.org/r/68813/diff/raw/ [1604/1604] ->
"68813.patch" [1]
> Checking 1 C++ file
> Done processing 3rdparty/stout/include/stout/option.hpp
> [MESOS-9056 6b57b1bcd] Added support for `Option<T&>` / `Option<const T&>`.
>  Author: Benjamin Mahler <bmahler@apache.org>
>  1 file changed, 44 insertions(+)
> ```
> The updated `cpplint.patch` has been created using `git diff`.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message