mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.
Date Fri, 05 Oct 2018 06:31:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68929/#review209252
-----------------------------------------------------------



We probably want to udpate the comment here.

https://github.com/apache/mesos/blob/6654b26918b464764ae0329cba3669b4566a8d60/src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp#L343-L349


src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 680 (patched)
<https://reviews.apache.org/r/68929/#comment293554>

    Looks like `infos[rootContainerId]->cgroup` is valid through out the scope, `const
string&` to save a copy



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 689 (patched)
<https://reviews.apache.org/r/68929/#comment293555>

    Since we expect to rarely hit here, I suggest to `LOG(INFO)` this. We might be grateful
someday :)


- Meng Zhu


On Oct. 4, 2018, 5:37 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68929/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-9295
>     https://issues.apache.org/jira/browse/MESOS-9295
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the nested container launch failure on the agent upgrade case.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 11dfbab182487c45fa494c41e31f777272b4b5d0

> 
> 
> Diff: https://reviews.apache.org/r/68929/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message