mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.
Date Thu, 04 Oct 2018 22:14:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 4, 2018, 10:14 p.m.)

Review request for mesos, Gilbert Song and Jie Yu.

Bugs: MESOS-9283

Repository: mesos


This patch updates the Docker library to consistently use the
overload of `subprocess()` which runs its binary via `exec()`
rather than through a shell. This makes it safe to use
`os::kill()` rather than `os::killtree()` when discarding
these commands, which this patch also accomplishes.


  src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 



`sudo bin/ --gtest_filter="*DOCKER*"`


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message